Change in vdsm[master]: stomp: server side subscriptions

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Mar 20 08:13:17 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: server side subscriptions
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 21: from vdsm.utils import monotonic_time
Line 22: import re
Line 23: 
Line 24: LEGACY_SUB_ID_REQ = "/queue/_local/vdsm/requests"
Line 25: LEGACY_SUB_ID_RES = "/queue/_local/vdsm/reponses"
> typo.
it is a typo but we used those names in 3.5 (with typo) so we need to keep them as they were. As I replied to your comment newer naming will be updated.
Line 26: 
Line 27: _RE_ESCAPE_SEQUENCE = re.compile(r"\\(.)")
Line 28: 
Line 29: _RE_ENCODE_CHARS = re.compile(r"[\r\n\\:]")


-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list