Change in vdsm[master]: devices: move and rename getUnderlyingDeviceAddress

fromani at redhat.com fromani at redhat.com
Thu Mar 19 07:57:24 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: devices: move and rename getUnderlyingDeviceAddress
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38714/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 515:     # Parse address to create proper dictionary.
Line 516:     # Libvirt device's address definition is:
Line 517:     # PCI = {'type':'pci', 'domain':'0x0000', 'bus':'0x00',
Line 518:     #        'slot':'0x0c', 'function':'0x0'}
Line 519:     # IDE = {'type':'drive', 'controller':'0', 'bus':'0', 'unit':'0'}
Let's bootstrap the unit tests with these examples
Line 520:     address = {}
Line 521:     for key in address_xml.attributes.keys():
Line 522:         address[key.strip()] = address_xml.getAttribute(key).strip()
Line 523: 


-- 
To view, visit https://gerrit.ovirt.org/38714
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45fefb65461bcf97f75d607c55097eb5db2ed2ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list