Change in vdsm[master]: devices: move and rename getUnderlyingDeviceAddress

danken at redhat.com danken at redhat.com
Mon Mar 16 09:49:14 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: devices: move and rename getUnderlyingDeviceAddress
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38714/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 511:     """
Line 512:     Obtain device's address from libvirt
Line 513:     """
Line 514:     address_xml = device_xml.getElementsByTagName('address')[index]
Line 515:     # Parse address to create proper dictionary.
this comment, with minor modifications, fits well into a docstring.

Thanks for this moving. Would you please also add a little unit test for this function.
Line 516:     # Libvirt device's address definition is:
Line 517:     # PCI = {'type':'pci', 'domain':'0x0000', 'bus':'0x00',
Line 518:     #        'slot':'0x0c', 'function':'0x0'}
Line 519:     # IDE = {'type':'drive', 'controller':'0', 'bus':'0', 'unit':'0'}


-- 
To view, visit https://gerrit.ovirt.org/38714
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45fefb65461bcf97f75d607c55097eb5db2ed2ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list