Change in vdsm[master]: virt: make updateVolume a periodic operation

fromani at redhat.com fromani at redhat.com
Wed Mar 18 16:27:04 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: make updateVolume a periodic operation
......................................................................


Patch Set 21:

(2 comments)

https://gerrit.ovirt.org/#/c/37594/21//COMMIT_MSG
Commit Message:

Line 11: 'updateVolumes' operation, which was formerly
Line 12: piggybacked in the sampling threads.
Line 13: 
Line 14: But actually 'updateVolumes' is a perfect candidate
Line 15: to motivy the need of a 'services' infrastructure to
motivate, and 'services' is now 'periodic'
Line 16: run periodic (bookkeeping) tasks for VMs.
Line 17: 
Line 18: So, this patch bootstraps the usage of the newly
Line 19: added services infrastructure by moving 'updateVolumes'


https://gerrit.ovirt.org/#/c/37594/21/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:

Line 55:     """
Line 56:     return interval / 2.
Line 57: 
Line 58: 
Line 59: def _dispatchedOperation(cif, func, period):
let's be pep8 friendly: rename (in the appropriate patch) to _dispatched_operation
Line 60:     disp = VmDispatcher(cif, _executor, func, _timeout_from(period))
Line 61:     return Operation(disp, period)
Line 62: 
Line 63: 


-- 
To view, visit https://gerrit.ovirt.org/37594
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list