Change in vdsm[master]: virt: make updateVolume a periodic operation
danken at redhat.com
danken at redhat.com
Wed Mar 18 16:27:05 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
......................................................................
Patch Set 21:
(3 comments)
https://gerrit.ovirt.org/#/c/37594/21/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Line 61: return Operation(disp, period)
Line 62:
Line 63:
Line 64: def start(cif):
Line 65: global _operations
must we create a new list?
Line 66:
Line 67: _scheduler.start()
Line 68: _executor.start()
Line 69:
Line 66:
Line 67: _scheduler.start()
Line 68: _executor.start()
Line 69:
Line 70: pervmOperation = functools.partial(_dispatchedOperation, cif)
per_vm_op
Line 71:
Line 72: _operations = [
Line 73: # needs dispatching becuse updating the volume stats needs the
Line 74: # access the storage, thus can block.
Line 222: def __init__(self, vm):
Line 223: self._vm = vm
Line 224:
Line 225: @property
Line 226: def runnable(self):
consider splitting this to two properties:
* runnable()
* required() ?
Line 227: # Avoid queries from storage during recovery process
Line 228: return (self._vm.isDisksStatsCollectionEnabled() and
Line 229: self._vm.isDomainReadyForCommands())
Line 230:
--
To view, visit https://gerrit.ovirt.org/37594
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list