Change in vdsm[master]: ceph: Support hotunplug of network disks
nsoffer at redhat.com
nsoffer at redhat.com
Tue Mar 17 08:44:07 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38804/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3142: continue
Line 3143: if device.UUID == drive["UUID"]:
Line 3144: return device
Line 3145:
Line 3146: elif drive.get('diskType') == 'network':
> For a future patch: have you planned to introduce constants for drive types
Good idea, we do need some constants there. I will add this in the next patches.
Line 3147: for device in self._devices[hwclass.DISK][:]:
Line 3148: if getattr(device, "diskType", None) != 'network':
Line 3149: continue
Line 3150: if device.path == drive["path"]:
--
To view, visit https://gerrit.ovirt.org/38804
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list