Change in vdsm[master]: ceph: Support hotunplug of network disks

fromani at redhat.com fromani at redhat.com
Tue Mar 17 07:44:53 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: ceph: Support hotunplug of network disks
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.ovirt.org/#/c/38804/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3142:                     continue
Line 3143:                 if device.UUID == drive["UUID"]:
Line 3144:                     return device
Line 3145: 
Line 3146:         elif drive.get('diskType') == 'network':
For a future patch: have you planned to introduce constants for drive types?
Line 3147:             for device in self._devices[hwclass.DISK][:]:
Line 3148:                 if getattr(device, "diskType", None) != 'network':
Line 3149:                     continue
Line 3150:                 if device.path == drive["path"]:


Line 3143:                 if device.UUID == drive["UUID"]:
Line 3144:                     return device
Line 3145: 
Line 3146:         elif drive.get('diskType') == 'network':
Line 3147:             for device in self._devices[hwclass.DISK][:]:
This reminds me that I need to review/enhance getDiskDevices(). In a hopefully not so far future we will kill the whole conf['devices'] and _devices madness.
Line 3148:                 if getattr(device, "diskType", None) != 'network':
Line 3149:                     continue
Line 3150:                 if device.path == drive["path"]:
Line 3151:                     return device


-- 
To view, visit https://gerrit.ovirt.org/38804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I730474c54802c2b0cbb685d8088d496ad565e36c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list