Change in vdsm[master]: vmdevices: test moving getUnderlying*Info
fromani at redhat.com
fromani at redhat.com
Fri Mar 13 12:00:14 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: vmdevices: test moving getUnderlying*Info
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38402/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 89: element.setAttrs(**elemAttrs)
Line 90: return element
Line 91:
Line 92: @staticmethod
Line 93: def _getLibvirtAddress(device_xml):
this could (and should) be a free function
Line 94: """
Line 95: Obtain device's address from libvirt
Line 96: """
Line 97: address = {}
--
To view, visit https://gerrit.ovirt.org/38402
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41caf127a8d3c674db98d5334f927233fa2c7c99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list