Change in vdsm[master]: openstacknet: add support for using the midonet plugin
danken at redhat.com
danken at redhat.com
Fri Mar 13 11:52:46 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet: add support for using the midonet plugin
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
I'm convinced that this causes no regression o bridge and ovs.
Please verify that it does what it should do for midonet.
https://gerrit.ovirt.org/#/c/36164/7/vdsm_hooks/openstacknet/README
File vdsm_hooks/openstacknet/README:
Line 16: via libvirt
English: parenthesis should close here!
https://gerrit.ovirt.org/#/c/36164/7/vdsm_hooks/openstacknet/openstacknet_utils.py
File vdsm_hooks/openstacknet/openstacknet_utils.py:
Line 97: bind_port
naming this mm_bind_port would make it clearer that it's a midonet-only function.
--
To view, visit https://gerrit.ovirt.org/36164
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7d582810e93cb4670a0fb1f6b3524e57a2617ae
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jean-François Joly <jf at midokura.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Ryu Ishimoto <ryu at midokura.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list