Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher

fromani at redhat.com fromani at redhat.com
Thu Mar 12 13:01:31 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: asyncore: Move ssl buffer handling to dispatcher
......................................................................


Patch Set 12:

(2 comments)

https://gerrit.ovirt.org/#/c/37097/12/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 87:             self.handle_accept()
Line 88:             return
Line 89: 
Line 90:         if not self.connected:
Line 91:             if self.connecting:
For my understanding: it is possible that self.connected=False and self.connecting=False ?
If so, when?
Line 92:                 self.handle_connect_event()
Line 93: 
Line 94:         self.handle_read()
Line 95: 


Line 92:                 self.handle_connect_event()
Line 93: 
Line 94:         self.handle_read()
Line 95: 
Line 96:         if hasattr(self.socket, "pending"):
can you please mention m2c sockets and thus the reason we need this check?
Line 97:             while self.socket.pending() > 0:
Line 98:                 self.handle_read()
Line 99: 
Line 100:     def recv(self, buffer_size):


-- 
To view, visit https://gerrit.ovirt.org/37097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list