Change in vdsm[master]: asyncore: Move generic reactor functionality

fromani at redhat.com fromani at redhat.com
Thu Mar 12 12:57:52 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: asyncore: Move generic reactor functionality
......................................................................


Patch Set 13:

(1 comment)

mostly OK, I just like a bit more docs. Should be quick and easy to add.

https://gerrit.ovirt.org/#/c/37055/13/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 134: 
Line 135: 
Line 136: class Reactor(object):
Line 137:     def __init__(self):
Line 138:         self._map = {}
can you please add documentation to this field? I don't reall grok the usage just from this code
Line 139:         self._is_running = False
Line 140:         self._wakeupEvent = AsyncoreEvent(self._map)
Line 141: 
Line 142:     def add_dispatcher(self, disp):


-- 
To view, visit https://gerrit.ovirt.org/37055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list