Change in vdsm[master]: jsonrpc: Properly initialize RuntimeError for JsonRpcError

fromani at redhat.com fromani at redhat.com
Tue Mar 10 09:47:26 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/35934/5//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-03-09 17:22:22 +0100
Line 6: 
Line 7: jsonrpc: Properly initialize RuntimeError for JsonRpcError
Line 8: 
Line 9: Without this the error doesn't have a proper message when printed\logged
silly comment (no need to change): I don't like backward slash, I automatically think about escaping next char, not about separating word.
Line 10: 
Line 11: Change-Id: Ic922a25e44ddc345d54dff19ffa6a93c461c1844


-- 
To view, visit https://gerrit.ovirt.org/35934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic922a25e44ddc345d54dff19ffa6a93c461c1844
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list