Change in vdsm[master]: stomp: Optimize stomp encoder\decoder

fromani at redhat.com fromani at redhat.com
Tue Mar 10 09:46:05 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: stomp: Optimize stomp encoder\decoder
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

seems nice, but we need better documentation (commit message) to start

https://gerrit.ovirt.org/#/c/35255/6//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-11-18 00:55:35 +0200
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2015-03-09 17:22:22 +0100
Line 6: 
Line 7: stomp: Optimize stomp encoder\decoder
which is nice, but looks like this patch squashes together a few changes related only by the topic (optimization).

This commit message is way too terse.
Can you please highlight and summarize the changes?

Maybe after that we can split this patch.
Line 8: 
Line 9: Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e


-- 
To view, visit https://gerrit.ovirt.org/35255
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list