Change in vdsm[master]: virt: Do not count time spent on migrationCreate against tim...

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Mon Mar 9 12:58:31 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: virt: Do not count time spent on migrationCreate against timeout
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38397/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 301:             # the migration to get cancelled right after the transfer started.
Line 302:             destinationCreateStartTime = time.time()
Line 303:             response = self.destServer.migrationCreate(self._machineParams)
Line 304:             # Adds the time spent on migrationCreate to the startTime
Line 305:             startTime += time.time() - destinationCreateStartTime
> OK, I got it better now, but I think it would be clearer if we take in acco
the original intent of counting it like this was to have a reliable/predictable total time limit for migrations. In order to not miss anything it's a bit better this way...

Note the destination creation is limited by its own mechanism (migration_listener_timeout) on dst, it's dynamic based on # of vms, so it complicates the source timeout, but at least it's not random
Line 306:             self.log.info('Creation of destination VM took: %d seconds',
Line 307:                           time.time() - destinationCreateStartTime)
Line 308: 
Line 309:             if response['status']['code']:


-- 
To view, visit https://gerrit.ovirt.org/38397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafdaa13136757d455e405328173aa3243bea3995
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list