Change in vdsm[master]: virt: Do not count time spent on migrationCreate against tim...

fromani at redhat.com fromani at redhat.com
Mon Mar 9 12:48:17 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: Do not count time spent on migrationCreate against timeout
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38397/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 301:             # the migration to get cancelled right after the transfer started.
Line 302:             destinationCreateStartTime = time.time()
Line 303:             response = self.destServer.migrationCreate(self._machineParams)
Line 304:             # Adds the time spent on migrationCreate to the startTime
Line 305:             startTime += time.time() - destinationCreateStartTime
OK, I got it better now, but I think it would be clearer if we take in account the actual time PLUS the time spent in hooks instead of taking the total time MINUS the time spent on migrationCreate.

But since it is fair to say that this may well be a pet peeve of mine, I don't really mind if code stay as it is right now.
Line 306:             self.log.info('Creation of destination VM took: %d seconds',
Line 307:                           time.time() - destinationCreateStartTime)
Line 308: 
Line 309:             if response['status']['code']:


-- 
To view, visit https://gerrit.ovirt.org/38397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafdaa13136757d455e405328173aa3243bea3995
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list