Change in vdsm[master]: janitorial: add the response.success() helper

fromani at redhat.com fromani at redhat.com
Mon Mar 9 10:26:12 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: janitorial: add the response.success() helper
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/38270/6/lib/vdsm/response.py
File lib/vdsm/response.py:

Line 25: def success(**kwargs):
Line 26:     kwargs["status"] = {
Line 27:         "code": 0,
Line 28:         "message": "Done"
Line 29:     }
> This duplicates doneCode - either remove it or use it here.
Since it is used in other places, will use it here and remove in a later patch, after we switched to response.success() everywhere
Line 30:     return kwargs
Line 31: 
Line 32: 
Line 33: def error(name, message=None):


-- 
To view, visit https://gerrit.ovirt.org/38270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list