Change in vdsm[master]: janitorial: add the response.success() helper
fromani at redhat.com
fromani at redhat.com
Mon Mar 9 10:21:56 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: janitorial: add the response.success() helper
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38270/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3387: self.cif.teardownVolumePath(memoryVol)
Line 3388:
Line 3389: # Returning quiesce to notify the manager whether the guest agent
Line 3390: # froze and flushed the filesystems or not.
Line 3391: quiesceFlag = (
> quiesceFlag is correct, but I would call it guestDidQuiesce - this flag tel
Done
Line 3392: snapFlags & libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE
Line 3393: == libvirt.VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE)
Line 3394: return response.success(quiesce=quiesceFlag)
Line 3395:
--
To view, visit https://gerrit.ovirt.org/38270
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list