Change in vdsm[master]: vm: drive: allow error policy fine tuning

nsoffer at redhat.com nsoffer at redhat.com
Fri Mar 6 22:22:19 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: drive: allow error policy fine tuning
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/38009/8//COMMIT_MSG
Commit Message:

Line 11: the guest OS, pausing the VM only if disk space was exhausted.
Line 12: 
Line 13: This approach was nice and simple, but sometimes just too limiting
Line 14: and some users asked for more fine-grained drive error policy
Line 15: control.
Currently we support only "stop" and "enospace", and we have mechanism for unpausing vms paused after EIO error.

How the new "report" and "ignore" integrate into the current code? What will happen when the guest when using these errors policies, and getting EIO error because a drive volume is not big enough (e.g, extending was too slow, or spm is down).
Line 16: 
Line 17: To allow that, we add a new Drive property, 'errorPolicy', which
Line 18: will superceed over the legacy, limited 'propagateErrors' tunable,
Line 19: in the case both are given.


-- 
To view, visit https://gerrit.ovirt.org/38009
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b1234ab15fc87ad75dfeae197d058eec23accbc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list