Change in vdsm[master]: qemu-img: Handle image end offset on different lines of output

danken at redhat.com danken at redhat.com
Wed Mar 4 11:00:48 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: qemu-img: Handle image end offset on different lines of output
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/38355/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 149:     # FIXME: handle different error codes and raise errors accordingly
Line 150:     if rc != 0:
Line 151:         raise QImgError(rc, out, err)
Line 152:     # Scan for 'offset' in the output
Line 153:     for row in xrange(CHECK_OPTFIELDS_STARTIDX, len(out)):
the output is not very long, and we should start thinking about Python3 - so please use range().
Line 154:         try:
Line 155:             check = {
Line 156:                 'offset': int(__iregexSearch("offset", out[row]))
Line 157:             }


https://gerrit.ovirt.org/#/c/38355/2/tests/qemuimgTests.py
File tests/qemuimgTests.py:

Line 337:     def test_convert_unsupported(self, **kw):
Line 338:         self.assertFalse(qemuimg._supports_src_cache('convert'))
Line 339: 
Line 340: 
Line 341: outputQemu2Check = """
are these new variables/constants expected to be used ever?
Line 342: No errors were found on the image.
Line 343: 65157/98304 = 66.28% allocated, 0.00% fragmented, 0.00% compressed clusters
Line 344: Image end offset: 4271243264
Line 345: """


-- 
To view, visit https://gerrit.ovirt.org/38355
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6610baf1702c9075d8512bdb1da0e05527a0060
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list