Change in vdsm[master]: qemu-img: Handle image end offset on different lines of output

tnisan at redhat.com tnisan at redhat.com
Wed Mar 4 09:43:28 UTC 2015


Tal Nisan has posted comments on this change.

Change subject: qemu-img: Handle image end offset on different lines of output
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Minor comment in the test

https://gerrit.ovirt.org/#/c/38355/2/tests/qemuimgTests.py
File tests/qemuimgTests.py:

Line 356:         def call(cmd, **kw):
Line 357:             out = ["No errors were found on the image.",
Line 358:                    "65157/98304 = 66.28% allocated, 0.00% fragmented, 0.00% "
Line 359:                    "compressed clusters",
Line 360:                    "Image end offset: 4271243264"]
s/ehd/end
Line 361:             return 0, out, []
Line 362: 
Line 363:         with MonkeyPatchScope([(utils, "execCmd", call)]):
Line 364:             check = qemuimg.check('unused')


-- 
To view, visit https://gerrit.ovirt.org/38355
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6610baf1702c9075d8512bdb1da0e05527a0060
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list