Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Jun 26 09:14:41 UTC 2015


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/42570/3/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 59:                                event)
Line 60:                 # Try to forcibly remove this FD from EPOLL
Line 61:                 # To really stop receiving events
Line 62:                 try:
Line 63:                     self._epoll.unregister(fileno)
> question: how about doing this in unregister()? Any drawback?
the point is that we are not tracking this filedescripter anymore, and by definition epoll should actually drop it when there was an error, however as can be seen in the linked bug (commit message) that there are loads and loads of errors happening. This is an attempt to be a safety mechanism to try to stop those errors.
Line 64:                 except IOError:
Line 65:                     pass
Line 66:         elif (event & select.EPOLLIN):
Line 67:             obj = self._channels.get(fileno, None)


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer%redhat.com at gtempaccount.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list