Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll
fromani at redhat.com
fromani at redhat.com
Wed Jun 24 11:49:55 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: virt: Forcibly unregister fds with errors from epoll
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
-1 for visibility because of a question inside
https://gerrit.ovirt.org/#/c/42570/3/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:
Line 59: event)
Line 60: # Try to forcibly remove this FD from EPOLL
Line 61: # To really stop receiving events
Line 62: try:
Line 63: self._epoll.unregister(fileno)
question: how about doing this in unregister()? Any drawback?
Line 64: except IOError:
Line 65: pass
Line 66: elif (event & select.EPOLLIN):
Line 67: obj = self._channels.get(fileno, None)
--
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer%redhat.com at gtempaccount.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list