Change in vdsm[master]: events: make sure to send only one event per status

ahadas at redhat.com ahadas at redhat.com
Tue Jun 23 07:39:15 UTC 2015


Arik Hadas has posted comments on this change.

Change subject: events: make sure to send only one event per status
......................................................................


Patch Set 2: Verified+1

(1 comment)

got one event for Down (the bug on engine side where the event is received on each host still exist, but with 1 host it works properly)

https://gerrit.ovirt.org/#/c/42579/2//COMMIT_MSG
Commit Message:

Line 10: event containing the same status. The assumtion is not true and there
Line 11: are flows where engine logic assumes only one status change.
Line 12: 
Line 13: One of the problematic flows is vm distroy for which having duplicate
Line 14: means that the operation failed and recovery flow is triggered.
> As I described in above commit message. The engine will make an assumption 
I think there are two cases:
1. The timestamp on the event is earlier than the one we got on poll - the engine will ignore the event
2. The timestamp on the poll is earlier than the one on the event - then the engine process the event.

So engine assumes that status that is returned by polling was sent by an event before.
Line 15: 
Line 16: 
Line 17: Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808


-- 
To view, visit https://gerrit.ovirt.org/42579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list