Change in vdsm[master]: events: make sure to send only one event per status

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Jun 22 06:39:19 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: events: make sure to send only one event per status
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/42579/2//COMMIT_MSG
Commit Message:

Line 10: event containing the same status. The assumtion is not true and there
Line 11: are flows where engine logic assumes only one status change.
Line 12: 
Line 13: One of the problematic flows is vm distroy for which having duplicate
Line 14: means that the operation failed and recovery flow is triggered.
> I don't really mind the vdsm-side patch, but what would happen on Engine it
As I described in above commit message. The engine will make an assumption that vm was not destroyed and will attempt to recover it.

The engine is making a lot of assumptions around vm life cycle and this is one of many.
Line 15: 
Line 16: 
Line 17: Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808


-- 
To view, visit https://gerrit.ovirt.org/42579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list