Change in vdsm[master]: serial console: add code to prepare the path

fromani at redhat.com fromani at redhat.com
Mon Jun 8 08:08:00 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: serial console: add code to prepare the path
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/41896/6//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: serial console: add code to prepare the path
Line 8: 
Line 9: Add support for vmconsole path preparation.
Line 10: The new supervdsm method ensures that the unix domain socket directory
> this seems a bit over-complex. Maybe I miss something, but task_mkdirs in v
I'm not a fan of doing setup in shell scripts in general, but that's another story. Will move the code in task_mkdirs, because I don't have a good reason not to do so.

Do you want to keep the check in python? (vmconsole.py:verify_directory)

should I move it to vdsmd_init_common.sh?
Line 11: needed by ovirt-vmconsole integration exists and has
Line 12: the following permissions, ownership and SELinux attributes:
Line 13: 
Line 14: /var/run/ovirt-vmconsole-console/ drwxrwxr-x. vdsm qemu system_u:object_r:qemu_var_run_t:s0


https://gerrit.ovirt.org/#/c/41896/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 195: 
Line 196:         ('ssl_protocol', 'sslv23',
Line 197:             'SSL protocol used by encrypted connection'),
Line 198: 
Line 199:         ('vm_console_enable', 'true',
> up to you of course, but in enterprise software usually a well behaved appl
As it is, if the directory doesn't pass basic sanity check, the VDSM fail to startup.

As a customer, I'd like to have easy opt-out when something so invasive is added, where feasible (e.g. here is trivially feasible, bulk stats transition is not).

Will drop this tunable for current patch. I'll add it back in a followup patch, if need arises/consensus forms.
Line 200:             'Enable VM serial console access using ovirt-vmconsole.'),
Line 201:     ]),
Line 202: 
Line 203:     # Section: [mom]


-- 
To view, visit https://gerrit.ovirt.org/41896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list