Change in vdsm[master]: serial console: add code to prepare the path
Alon Bar-Lev
alonbl at redhat.com
Fri Jun 5 17:20:39 UTC 2015
Alon Bar-Lev has posted comments on this change.
Change subject: serial console: add code to prepare the path
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/41896/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 195:
Line 196: ('ssl_protocol', 'sslv23',
Line 197: 'SSL protocol used by encrypted connection'),
Line 198:
Line 199: ('vm_console_enable', 'true',
> why do we want to make this configurable? Any reason a user would like not
up to you of course, but in enterprise software usually a well behaved application should enable customization to perform on site support if something is misbehaving.
Line 200: 'Enable VM serial console access using ovirt-vmconsole.'),
Line 201: ]),
Line 202:
Line 203: # Section: [mom]
--
To view, visit https://gerrit.ovirt.org/41896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list