Change in vdsm[master]: virt: Change state of the agent only after heartbeat processing

danken at redhat.com danken at redhat.com
Mon Jul 27 11:05:03 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Change state of the agent only after heartbeat processing
......................................................................


virt: Change state of the agent only after heartbeat processing

Until now we have been setting the guest agent state to up,
for every message we are receiving from the guest agent.

With the new events implementation this has the side effect,
that the data from the event has not been consumed yet but the
change will trigger the event being fired that the VM is UP.

This patch changes this old behaviour to only change the internal
state on heartbeat messages, and only after the data has been
consumed.

Change-Id: I541d3a4ad2930715d38c8908e2c5d6543ad72037
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/43859
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Tested-by: Omer Frenkel <ofrenkel at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/guestagent.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Omer Frenkel: Verified
  Michal Skrivanek: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/43859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I541d3a4ad2930715d38c8908e2c5d6543ad72037
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list