Change in vdsm[master]: virt: Change state of the agent only after heartbeat processing

danken at redhat.com danken at redhat.com
Mon Jul 27 11:04:59 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: Change state of the agent only after heartbeat processing
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/43859/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-07-21 14:52:44 +0200
Line 4: Commit:     Vinzenz Feenstra <vfeenstr at redhat.com>
Line 5: CommitDate: 2015-07-21 14:57:34 +0200
Line 6: 
Line 7: virt: Change state of the agent only after heartbeat processing
> No, there won't be any difference. Actually it solves the same potential is
It does mean that we move to "Running" a bit later (on average). But it's not a big deal at all.
Line 8: 
Line 9: Until now we have been setting the guest agent state to up,
Line 10: for every message we are receiving from the guest agent.
Line 11: 


-- 
To view, visit https://gerrit.ovirt.org/43859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I541d3a4ad2930715d38c8908e2c5d6543ad72037
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list