Change in vdsm[master]: virt: graphdev: support headless VM

danken at redhat.com danken at redhat.com
Tue Jul 14 11:27:25 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: graphdev: support headless VM
......................................................................


Patch Set 27: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/27846/27/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 612:         Normalize graphics device provided by conf.
Line 613:         """
Line 614: 
Line 615:         # this method needs to cope both with ancient Engines and with
Line 616:         # recent Engines unaware of graphic devices.
Please do a little research and add a comment

 # REQUIRED_FOR: engine <= 3.???

if 3.4 always sends "display", we can drop this legacy code.
Line 617:         if 'display' not in self.conf:
Line 618:             return []
Line 619: 
Line 620:         return [{


-- 
To view, visit https://gerrit.ovirt.org/27846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list