Change in vdsm[master]: virt: add logic for POWER cpu xml element
danken at redhat.com
danken at redhat.com
Tue Jul 14 11:09:52 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: virt: add logic for POWER cpu xml element
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42736/7/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 392: elif feature[0] == '-':
Line 393: featureAttrs['policy'] = 'disable'
Line 394: cpu.appendChildWithArgs('feature', **featureAttrs)
Line 395: elif self.arch in caps.Architecture.POWER:
Line 396: features = self.conf.get('cpuType', 'POWER8').split(',')
please require a libvirt version that supports 'POWER8'
Line 397: model = features[0]
Line 398: cpu.appendChildWithArgs('model', text=model)
Line 399:
Line 400: if ('smpCoresPerSocket' in self.conf or
--
To view, visit https://gerrit.ovirt.org/42736
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9303b76904ef1344508136343104b37c09d2a370
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list