Change in vdsm[master]: sampling: make _getCpuCoresStats a function

danken at redhat.com danken at redhat.com
Tue Jul 7 10:31:50 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: sampling: make _getCpuCoresStats a function
......................................................................


Patch Set 16: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/40429/16/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 736:         ) % JIFFIES_BOUND
Line 737:         return ("%.2f" % (jiffies / interval))
Line 738: 
Line 739:     cpu_core_stats = {}
Line 740:     for node_index, numa_node in caps.getNumaTopology().items():
let's not create a needless copy of a possibly-long list.

starting to use

  six.moves.items()

would be nice.
Line 741:         cpu_cores = numa_node['cpus']
Line 742:         for cpu_core in cpu_cores:
Line 743:             core_stat = {
Line 744:                 'nodeIndex': int(node_index),


-- 
To view, visit https://gerrit.ovirt.org/40429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If602a84096db7aa7d1a6672b84d62287e08b0ac2
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list