Change in vdsm[master]: lib: migration: add response helpers

danken at redhat.com danken at redhat.com
Tue Jul 7 10:24:37 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: lib: migration: add response helpers
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/42795/4/lib/vdsm/response.py
File lib/vdsm/response.py:

Line 23: from vdsm.define import doneCode
Line 24: from vdsm.define import errCode
Line 25: 
Line 26: 
Line 27: class Malformed(Exception):
> Adding Error suffix for all exceptions is bad idea, and unfortunately very 
Why is the common Error suffix a bad idea? It's almost a standard.
Line 28:     """
Line 29:     Malformed response value
Line 30:     """
Line 31: 


-- 
To view, visit https://gerrit.ovirt.org/42795
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list