Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Jul 6 08:49:54 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: xmlrpc: do not block forever when waiting on incoming messages
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/42915/5//COMMIT_MSG
Commit Message:

Line 13: protocol and pass socket for processing.
Line 14: 
Line 15: This patch changes how request queue is managed. We want to be sure that
Line 16: when we stop only sentinel is queued so the xmlrpc server thread is
Line 17: properly closed.
> The code is nice, but it does not fix blocking issue. The only change is dr
Done
Line 18: 
Line 19: 
Line 20: Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a


-- 
To view, visit https://gerrit.ovirt.org/42915
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list