Change in vdsm[master]: resize-lun: resizePV parameters

frolland at redhat.com frolland at redhat.com
Mon Jul 6 08:42:35 UTC 2015


Freddy Rolland has posted comments on this change.

Change subject: resize-lun: resizePV parameters
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/42608/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 876:     Raises se.CouldNotResizePhysicalVolume if pvresize fails
Line 877:     """
Line 878:     pvName = _fqpvname(guid)
Line 879:     cmd = ["pvresize", pvName]
Line 880:     rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
> Good point - Fred, please check what happens when multiple pvs can be resiz
I tested and it will resize only the guid one.
Line 881:     if rc != 0:
Line 882:         raise se.CouldNotResizePhysicalVolume(pvName, err)
Line 883:     _lvminfo._invalidatepvs(pvName)
Line 884:     _lvminfo._invalidatevgs(vgName)


Line 876:     Raises se.CouldNotResizePhysicalVolume if pvresize fails
Line 877:     """
Line 878:     pvName = _fqpvname(guid)
Line 879:     cmd = ["pvresize", pvName]
Line 880:     rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, )))
> Would this silently pvresize all the devices in the VG instead of just the 
I tested and it will resize only the guid one.
The additional devices are needed in the filter
Line 881:     if rc != 0:
Line 882:         raise se.CouldNotResizePhysicalVolume(pvName, err)
Line 883:     _lvminfo._invalidatepvs(pvName)
Line 884:     _lvminfo._invalidatevgs(vgName)


-- 
To view, visit https://gerrit.ovirt.org/42608
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list