Change in vdsm[master]: profiling: avoid to crash VDSM if yappi is missing

fromani at redhat.com fromani at redhat.com
Mon Jan 5 10:58:00 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: profiling: avoid to crash VDSM if yappi is missing
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.ovirt.org/#/c/36012/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-12-09 09:20:23 +0100
Line 4: Commit:     Francesco Romani <fromani at redhat.com>
Line 5: CommitDate: 2014-12-17 11:05:17 +0100
Line 6: 
Line 7: profiling: avoid to crash VDSM if yappi is missing
> avoid to crash VDSM if -> Avoid crash if
Done
Line 8: 
Line 9: Add protection around lazy yappi import
Line 10: to avoid crashing VDSM in presence of inconsistent
Line 11: configuration: profiling enabled but yappi package


Line 8: 
Line 9: Add protection around lazy yappi import
Line 10: to avoid crashing VDSM in presence of inconsistent
Line 11: configuration: profiling enabled but yappi package
Line 12: not installed.
> I'm not sure that we need this protection - if you enable the cpu profiler 
I don't have particulary strong feelings about this patch, I added for consistency, so it really boils down to how memory profiler fails. See below.
Line 13: 
Line 14: Provide error message explaining the failure, and
Line 15: add consistency with more complex memory profiling
Line 16: which benefits of this protection, and has


Line 13: 
Line 14: Provide error message explaining the failure, and
Line 15: add consistency with more complex memory profiling
Line 16: which benefits of this protection, and has
Line 17: a more complex setup.
> Why the memory profiler cannot use the same logic as the cpu profiler is us
Earliest attempts shown that the dowser profile silently fails if a required package (PIL) was missing. I don't like that. A loud failure (even a crash) is OK, a silent failure is not.

Maybe I missed something in my tests. I'll check again and if I can make dowser (memory profiler) fail loudly, I'll just drop this patch.
Line 18: 
Line 19: Change-Id: I8272b25afe507038f930929f4b51d6d8f5b73495


-- 
To view, visit http://gerrit.ovirt.org/36012
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8272b25afe507038f930929f4b51d6d8f5b73495
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list