Change in vdsm[master]: profile: transform into a subpackage

fromani at redhat.com fromani at redhat.com
Mon Jan 5 10:22:31 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: profile: transform into a subpackage
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/36010/3/lib/vdsm/profiling/__init__.py
File lib/vdsm/profiling/__init__.py:

Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
> Having code in __init__ is confusing, you never know what is a module and w
I share your feeling about code in __init__.py

I took this route because only because I failed to find a better (nicer and simple to use) approach. I'll think a bit in the direction you outlined, which seems promising.
Line 21: import cpu
Line 22: 
Line 23: 
Line 24: def start():


http://gerrit.ovirt.org/#/c/36010/3/tests/profileTests.py
File tests/profileTests.py:

Line 44
Line 45
Line 46
Line 47
Line 48
> Lets separate this change it its own patch before this one.
fair point.


-- 
To view, visit http://gerrit.ovirt.org/36010
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfd925e566a9af69d4b42a70fa835b072bb1f7a0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list