Change in vdsm[master]: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool ...

danken at redhat.com danken at redhat.com
Mon Feb 23 18:08:06 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool and _to_ifcfg_bool
......................................................................


ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool and _to_ifcfg_bool

Use them to format the defaultRoute=True/False property to DEFROUTE=yes/no
without the need to replace the value in IpConfig's namedtuple first and
also to override the property with information from an existing ifcfg file.

If DEFROUTE is not present it is stored as None and not printed to an ifcfg
file at all. To simplify the situation (as seen in other configurators) only
True/False could be used in the future not only in defaultRoute but in other
IP configuration parameters.

Change-Id: I87069ee99fb39d4ce100ccc03117c5a7c88b3e96
Signed-off-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/37792
Reviewed-by: Petr Horáček <phoracek at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Petr Horáček <phoracek at redhat.com>
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 16 insertions(+), 19 deletions(-)

Approvals:
  Petr Horáček: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/37792
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87069ee99fb39d4ce100ccc03117c5a7c88b3e96
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list