Change in vdsm[master]: models: rename NetDevice.ip to ipconfig to be more descriptive

osvoboda at redhat.com osvoboda at redhat.com
Mon Feb 23 17:28:07 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: models: rename NetDevice.ip to ipconfig to be more descriptive
......................................................................


Patch Set 6:

(1 comment)

I'll revert the parentheses.

http://gerrit.ovirt.org/#/c/37797/6/vdsm/network/models.py
File vdsm/network/models.py:

Line 47:     def configure(self, **opts):
Line 48:         raise NotImplementedError
Line 49: 
Line 50:     @property
Line 51:     def ipConfig(self):
> this is a horrible and frightening intermediate stage!
Welcome to the jungle :-D
Line 52:         return self.ipconfig.getConfig()
Line 53: 
Line 54:     @property
Line 55:     def bridge(self):


-- 
To view, visit http://gerrit.ovirt.org/37797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3aae9ec5cd0bb8eea6022935f1836a1a44bf848
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list