Change in vdsm[master]: virt: Improve volume extension info readability

nsoffer at redhat.com nsoffer at redhat.com
Sun Feb 22 14:22:29 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: virt: Improve volume extension info readability
......................................................................

virt: Improve volume extension info readability

Format dict using one line per item and sort by the key. This makes the
code easier to read and modify.

Change-Id: Ieaf5b629f927094de04897d718d41ee81ed30ffb
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 17 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/38029/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 8c11759..c8ba021 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1515,10 +1515,15 @@
         self.__extendDriveVolume(vmDrive, vmDrive.volumeID, volInfo['newSize'])
 
     def __extendDriveVolume(self, vmDrive, volumeID, newSize):
-        volInfo = {'poolID': vmDrive.poolID, 'domainID': vmDrive.domainID,
-                   'imageID': vmDrive.imageID, 'volumeID': volumeID,
-                   'name': vmDrive.name, 'newSize': newSize,
-                   'internal': bool(vmDrive.volumeID != volumeID)}
+        volInfo = {
+            'domainID': vmDrive.domainID,
+            'imageID': vmDrive.imageID,
+            'internal': bool(vmDrive.volumeID != volumeID),
+            'name': vmDrive.name,
+            'newSize': newSize,
+            'poolID': vmDrive.poolID,
+            'volumeID': volumeID,
+        }
         self.log.debug("Requesting an extension for the volume: %s", volInfo)
         self.cif.irs.sendExtendMsg(
             vmDrive.poolID,
@@ -1527,12 +1532,14 @@
             self.__afterVolumeExtension)
 
     def __extendDriveReplica(self, drive, newSize):
-        volInfo = {'poolID': drive.diskReplicate['poolID'],
-                   'domainID': drive.diskReplicate['domainID'],
-                   'imageID': drive.diskReplicate['imageID'],
-                   'volumeID': drive.diskReplicate['volumeID'],
-                   'name': drive.name,
-                   'newSize': newSize}
+        volInfo = {
+            'domainID': drive.diskReplicate['domainID'],
+            'imageID': drive.diskReplicate['imageID'],
+            'name': drive.name,
+            'newSize': newSize,
+            'poolID': drive.diskReplicate['poolID'],
+            'volumeID': drive.diskReplicate['volumeID'],
+        }
         self.log.debug("Requesting an extension for the volume "
                        "replication: %s", volInfo)
         self.cif.irs.sendExtendMsg(drive.poolID,


-- 
To view, visit http://gerrit.ovirt.org/38029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieaf5b629f927094de04897d718d41ee81ed30ffb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list