Change in vdsm[master]: virt: Remove redundant bool()

nsoffer at redhat.com nsoffer at redhat.com
Sun Feb 22 14:22:29 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: virt: Remove redundant bool()
......................................................................

virt: Remove redundant bool()

Comparisons yield boolean values, there is no need for creating a new
bool() from the result.

See https://docs.python.org/2/reference/expressions.html#not-in

Change-Id: Ie561ae9b31969adc3e64aab023628fa56d910416
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/38030/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c8ba021..98aaeb1 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1518,7 +1518,7 @@
         volInfo = {
             'domainID': vmDrive.domainID,
             'imageID': vmDrive.imageID,
-            'internal': bool(vmDrive.volumeID != volumeID),
+            'internal': vmDrive.volumeID != volumeID,
             'name': vmDrive.name,
             'newSize': newSize,
             'poolID': vmDrive.poolID,


-- 
To view, visit http://gerrit.ovirt.org/38030
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie561ae9b31969adc3e64aab023628fa56d910416
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list