Change in vdsm[master]: netinfo: _bridges_ should be among devices with active DHCP ...

osvoboda at redhat.com osvoboda at redhat.com
Tue Feb 10 12:34:54 UTC 2015


Ondřej Svoboda has abandoned this change.

Change subject: netinfo: _bridges_ should be among devices with active DHCP leases
......................................................................


Abandoned

I never bothered to read the default value in

    netAttr.get('iface', net) 

which indeed results in passing (to _getNetInfo) the 'iface' if available (i.e. the network is _not_ bridged, see networks()), otherwise the network/bridge name.

A relevant part of networks():

            if len(interfaces) > 0:
                nets[netname]['iface'] = interfaces[0].getAttribute('dev')
                nets[netname]['bridged'] = False
            else:
                nets[netname]['bridge'] = \
                    xml.getElementsByTagName('bridge')[0].getAttribute('name')
                nets[netname]['bridged'] = True

-- 
To view, visit http://gerrit.ovirt.org/37636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I6e6d9dc729bed6e395c58888b13b1a779b4acc95
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list