Change in vdsm[master]: netinfo: _bridges_ should be among devices with active DHCP ...

danken at redhat.com danken at redhat.com
Tue Feb 10 10:26:05 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: _bridges_ should be among devices with active DHCP leases
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/37636/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 648:         dhcpv4_ifaces, dhcpv6_ifaces = _get_dhclient_ifaces()
Line 649:     d = {}
Line 650:     for net, netAttr in nets.iteritems():
Line 651:         try:
Line 652:             d[net] = _getNetInfo(net, netAttr.get('iface', net),
I think that this patch is redundant, as we already pass the bridge name if the network is not defined on an iface.

  netAttr.get('iface', net)
Line 653:                                  netAttr['bridged'], routes, ipAddrs,
Line 654:                                  dhcpv4_ifaces, dhcpv6_ifaces)
Line 655:         except KeyError:
Line 656:             continue  # Do not report missing libvirt networks.


-- 
To view, visit http://gerrit.ovirt.org/37636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e6d9dc729bed6e395c58888b13b1a779b4acc95
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list