Change in vdsm[master]: Add feature to create dispersed volume

barumuga at redhat.com barumuga at redhat.com
Fri Feb 6 10:19:23 UTC 2015


Bala.FA has posted comments on this change.

Change subject: Add feature to create dispersed volume
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/37474/4/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 475: 
Line 476: 
Line 477: @makePublic
Line 478: def volumeCreate(volumeName, brickList, replicaCount=0, stripeCount=0,
Line 479:                  transportList=[], force=False, options=None):
> I remember we have added this 'options' param for later use to provide back
Why is the backward compatibility problem when add them as optional param everywhere in the code?
Line 480:     command = _getGlusterVolCmd() + ["create", volumeName]
Line 481:     if stripeCount:
Line 482:         command += ["stripe", "%s" % stripeCount]
Line 483:     if replicaCount:


-- 
To view, visit http://gerrit.ovirt.org/37474
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50f6dbae8d179c09480634c64d7d439ae82d72a2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list