Change in vdsm[master]: Add feature to create dispersed volume

tjeyasin at redhat.com tjeyasin at redhat.com
Fri Feb 6 07:47:30 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: Add feature to create dispersed volume
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.ovirt.org/#/c/37474/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-02-03 16:11:16 +0530
Line 4: Commit:     Timothy Asir <tjeyasin at redhat.com>
Line 5: CommitDate: 2015-02-04 17:25:09 +0530
Line 6: 
Line 7: Add feature to create dispersed volume
> prefix gluster:
Done
Line 8: 
Line 9: Added disperse count and redundancy count params into
Line 10: create volume function which provides options to create
Line 11: a dispersed volume.


http://gerrit.ovirt.org/#/c/37474/4/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 475: 
Line 476: 
Line 477: @makePublic
Line 478: def volumeCreate(volumeName, brickList, replicaCount=0, stripeCount=0,
Line 479:                  transportList=[], force=False, options=None):
> Why not disperseCount=0 and redundancy=0?
I remember we have added this 'options' param for later use to provide backward compatibility. I just added the params into options to make use of it.
Also i feel adding params separately here will expect changes in volumeCreate function in api.py also.

if we have to add the params separately then what is your suggestion on api.py. How are we going to support the backward compatibility.
Line 480:     command = _getGlusterVolCmd() + ["create", volumeName]
Line 481:     if stripeCount:
Line 482:         command += ["stripe", "%s" % stripeCount]
Line 483:     if replicaCount:


-- 
To view, visit http://gerrit.ovirt.org/37474
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50f6dbae8d179c09480634c64d7d439ae82d72a2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list