Change in vdsm[master]: vm: nic hotunplug, perform libvirt operation before modyfing...

danken at redhat.com danken at redhat.com
Thu Dec 31 14:59:32 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vm: nic hotunplug, perform libvirt operation before modyfing vdsm nic objects
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51193/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2288
Line 2289
Line 2290
Line 2291
Line 2292
please dig deeper in the logs - I think that we had worse cases when we removed the devices after the libvirt call.

(but a horrible race exists anyway)


-- 
To view, visit https://gerrit.ovirt.org/51193
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ba3c622fa92e9c0898860eb93f6bb42bee3041
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list