Change in vdsm[master]: Added the option to scan alignment directly according to a c...

nsoffer at redhat.com nsoffer at redhat.com
Thu Dec 31 12:55:39 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Added the option to scan alignment directly according to a config value
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40402/5//COMMIT_MSG
Commit Message:

Line 4: Commit:     Tal Nisan <tnisan at redhat.com>
Line 5: CommitDate: 2015-12-30 17:03:04 +0200
Line 6: 
Line 7: Added the option to scan alignment directly according to a config value
Line 8: 
> can you explain why is this good for?
I talked with ydray about this workaround, and we agreed that this should be enabled by default for all platform effected by this issue.

If we don't have a reason to disable the direct scan, I think we should avoid adding configuration for this, and enable it dynamically based on the current platform or libvirt version.
Line 9: Bug-Url: https://bugzilla.redhat.com/1151838
Line 10: Change-Id: I00d8b681e4d2a2f4fb60e673eefdc807d8e1447d


-- 
To view, visit https://gerrit.ovirt.org/40402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00d8b681e4d2a2f4fb60e673eefdc807d8e1447d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list