Change in vdsm[master]: Remove koji build flag and use specific one for vhostmd

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 22 11:17:27 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Remove koji build flag and use specific one for vhostmd
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/49427/4/configure.ac
File configure.ac:

Line 60: AC_ARG_ENABLE(
Line 61:     [vhostmd],
Line 62:     [AS_HELP_STRING(
Line 63:         [--enable-vhostmd],
Line 64:         [build vhostmd subpackage @<:@default=no@:>@]
> actually I've asked to call it "vdsm-hook-vhostmd subpackage". Sorry for be
Lets change the name of the flag to "--enable-vhostdm-hook"

This will make it very clear what it does.
Line 65:     )],
Line 66:     [enable_vhostmd="no"]
Line 67: )
Line 68: AS_IF([test "${enable_vhostmd}" = "yes"],


-- 
To view, visit https://gerrit.ovirt.org/49427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2401a803243e3e64216fe62039c1b15c431a906
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list