Change in vdsm[master]: virt: Handle fork() related issues in vmchannels/guestagent
nsoffer at redhat.com
nsoffer at redhat.com
Tue Dec 22 11:15:02 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: virt: Handle fork() related issues in vmchannels/guestagent
......................................................................
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/42570/13/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:
Line 123: for fileno in self._del_channels:
Line 124: self._add_channels.pop(fileno, None)
Line 125: self._unconnected.pop(fileno, None)
Line 126: self._channels.pop(fileno, None)
Line 127: self._epoll_remove(fileno)
> If we're here, stop has been called and close should have been called from
We unregister after the fd was closed? It should be in the opposite order.
Line 128: self.log.debug("fileno %d was removed from listener.", fileno)
Line 129: self._del_channels = []
Line 130:
Line 131: def _update_channels(self):
--
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer%redhat.com at gtempaccount.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list