Change in vdsm[master]: schema: introduce HostJobInfo type

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Dec 15 09:38:57 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: schema: introduce HostJobInfo type
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 4057: # @ErrorInfo:
Line 4058: #
Line 4059: # Information about an error
Line 4060: #
Line 4061: # @code:         An error code
> No, we have several error codes in various modules, not related to this cha
Not specifically to this patch but when we create an api which is used by many devs it is good practice to have unique codes which could be easily understood by the client.
Line 4062: #
Line 4063: # @message:      A free-form description of the error
Line 4064: #
Line 4065: # Since: 4.18


Line 4089: #
Line 4090: # Since: 4.18
Line 4091: ##
Line 4092: {'type': 'HostJobInfo',
Line 4093:  'data': {
> The current format is unreadable, it time to format data in a readable way.
Please do not introduce new format. I am working on adding more value to the schema and some significant changes to have we process it. Soon to be published.
Line 4094:      'id': 'UUID',
Line 4095:      'description': 'str',
Line 4096:      'job_type': 'HostJobType',
Line 4097:      'status': 'HostJobStatus',


-- 
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list