Change in vdsm[master]: schema: introduce HostJobInfo type

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 15 09:28:59 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: schema: introduce HostJobInfo type
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 4022: 
Line 4023: ##
Line 4024: # @HostJobType:
Line 4025: #
Line 4026: # The type of a @HostJob (string)
> It is nice additional information but until now we haven't provided it.
We should start to specify this. Otherwise people are confused about the values - the order of the strings does not matter, and the values must be the actual string, not the index of the string in the list.

We have some old storage api that use numbers instead of strings. It must be clear that this is not valid.
Line 4027: #
Line 4028: # @storage:  Storage job
Line 4029: #
Line 4030: # @v2v:      v2v job


Line 4057: # @ErrorInfo:
Line 4058: #
Line 4059: # Information about an error
Line 4060: #
Line 4061: # @code:         An error code
> Do we have common place to store the codes to keep them unique? If so pleas
No, we have several error codes in various modules, not related to this change.
Line 4062: #
Line 4063: # @message:      A free-form description of the error
Line 4064: #
Line 4065: # Since: 4.18


Line 4089: #
Line 4090: # Since: 4.18
Line 4091: ##
Line 4092: {'type': 'HostJobInfo',
Line 4093:  'data': {
> Looking at the schema we seem to have different convention to format data. 
The current format is unreadable, it time to format data in a readable way.
Line 4094:      'id': 'UUID',
Line 4095:      'description': 'str',
Line 4096:      'job_type': 'HostJobType',
Line 4097:      'status': 'HostJobStatus',


-- 
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list